-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDSC loses key when closing Safari #55
Comments
This sounds like a browser thing to me. Local storage is a browser API that we leverage; is your browser set to discard data on exit? |
I haven't used FDSC on my MacBook's Safari since quite a lot of time, but IIRC (I may be wrong), it worked properly. I'll check this during spam-o-clock tomorrow. |
I have other scripts installed and they don't lose their stored data. I'll test it with an other browser this weekend |
I've grepped the FDSC code for "local" and there doesn't seem to be any code to delete stuff from local storage. The only time it writes to the storage is when you enter the authentication token. I've never seen this issue happen either to me (FF/Win10/barely ever restart) or in the chat. That being said, FDSC uses some cross-domain storage and I'm not entirely sure how it works. Others are welcome to investigate further. |
@honnza effectively, all the local storage is actually stored on the metasmoke domain; other domains query it. |
I could not reproduce it with Chrome 56.0.2924.87 with the latest version of Tampermonkey. :-/ |
I use Safari, and this happens to me as well. |
I recently had issues with FDSC, because I had to grant the permission again and again. (see chat)
Now, I found out, when exactly this happens: When I restart Safari, the local storage for the FDSC-script (and only for this!) is deleted which results in an empty
fdsc_msWriteToken
.Is there any additional option, I need to set in Tampermonkey to keep the token in the storage?
The text was updated successfully, but these errors were encountered: