Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Change helper function export names so that auto-imports pull from index instead of helper function file. #74

Closed
quisido opened this issue May 13, 2019 · 1 comment
Assignees
Labels
feature A new feature is requested.
Milestone

Comments

@quisido
Copy link
Collaborator

quisido commented May 13, 2019

Currently, the user receives "globalStateManager.set is not a function" when trying to setGlobal (helper function) -- probably due to globalStateManager being undefined or null.

Root cause appears to be importing React from react instead of reactn.

If globalStateManager is null, throw an Error saying to import from the correct package.

@quisido quisido self-assigned this May 13, 2019
@quisido quisido added the feature A new feature is requested. label May 13, 2019
@quisido quisido modified the milestones: 2.0.1, 2.0.2 May 13, 2019
@quisido quisido modified the milestones: 2.0.2, 2.0.3 May 23, 2019
@quisido quisido changed the title Throw more helpful error when React is not imported from reactn. Change helper function export names so that auto-imports pull from index instead of helper function file. Jun 1, 2019
@quisido
Copy link
Collaborator Author

quisido commented Jun 1, 2019

I am using Webstorm and when i use autocomplete is exports setGlobal from "reactn/build/set-global".

@quisido quisido closed this as completed in 8cbede4 Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature is requested.
Projects
None yet
Development

No branches or pull requests

1 participant