Add method in ContactSelf to update name and signature #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from chatie
This reverts commit 33c4321.
|
Here is the c9 playgound Please let me know your thought. |
huan
reviewed
Aug 6, 2018
src/user/contact-self.ts
Outdated
| @@ -115,4 +115,21 @@ export class ContactSelf extends Contact { | |||
| return qrcodeData | |||
| } | |||
|
|
|||
| public async setName (name: string): Promise<boolean> { | |||
| log.verbose('Contact-self', 'setName()') | |||
|
Two more things:
|
Any other comments besides the |
|
Thank you very much for the new features! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a prototype. It is adding two new method to
ContactSelfclass.setNameto change the nick name of the botsignatureto change the signature of the botWill provide c9 playground link for working prototype in following comment