-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add receive and send link prototype #1538
Conversation
Thanks for the PR. However, please move all the discussion to an issue before you create a PR, and only keep the issue number in the PR content, which I think it's better to show what's happened in the CHANGELOG. |
Got it, will create issue next time. |
Thanks for the prototyping. I had added a new class named Merged. |
It seems like the current design for |
The best practice is to keep the date immutable as possible as we can. If you want to change those values, you can do that by creating a new UrlLink. Or could you provide a scenario that can prove we have to support mutation? |
But even create a new UrlLink, the I think either we support modifying the link or creating new I can not come up with use cases modifying the What do you think? |
Please file another issue for this immutable discuss because this is a closed PR, and let's track it more clear. |
Okay, issue created: #1541 |
See #1539