Fixing .f12 scripts for python packages

There were two problems: 1. The `*` glob pattern was not functioning because of the quotes 2. The `--target` option does not work in combination with namespace packages: pypa/pip#10110 Both problems would have been caught in the first place if this has been thoroughly tested. Sorry. Change-Id: I2e0829cb9fbe160289e7340d79087a62563121a1
Checkmk · Mar 26, 2024 · 88914a1 · 88914a1
1 parent 86d2e57
commit 88914a1
Show file tree

Hide file tree

Showing 8 changed files with 40 additions and 8 deletions.
diff --git a/packages/cmk-agent-based/.f12 b/packages/cmk-agent-based/.f12
@@ -13,10 +13,14 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation.
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
diff --git a/packages/cmk-agent-receiver/.f12 b/packages/cmk-agent-receiver/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then

diff --git a/packages/cmk-graphing/.f12 b/packages/cmk-graphing/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then

diff --git a/packages/cmk-livestatus-client/.f12 b/packages/cmk-livestatus-client/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then

diff --git a/packages/cmk-mkp-tool/.f12 b/packages/cmk-mkp-tool/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then

diff --git a/packages/cmk-rulesets/.f12 b/packages/cmk-rulesets/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then

diff --git a/packages/cmk-server-side-calls/.f12 b/packages/cmk-server-side-calls/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then

diff --git a/packages/cmk-werks/.f12 b/packages/cmk-werks/.f12
@@ -13,12 +13,16 @@
 
 pipenv run pip wheel --no-deps --wheel-dir build .
 
+# pip installs the package in the user directory in case of missing permissions
+# this might be surprising and hard to spot, so we force the global installation
+# hint: use `omd-setup-version-for-dev` to fix permissions of the checkmk site.
+export PYTHONNOUSERSITE=1
+
 "/omd/sites/${SITE}/bin/python3" -m pip install \
     --no-deps \
     --upgrade \
     --force-reinstall \
     --isolated \
-    --target "/omd/sites/${SITE}/lib/python3.*/site-packages/" \
     ./build/*-*-py3-none-any.whl
 
 if [ -z "$ONLY_COPY" ]; then