[WIP] File System persisted queries #858
Conversation
That is good, I have already started work on this on the client branch. I will merge that soon. |
I think I can merge something tomorrow for you- |
| /// <summary> | ||
| /// A tool for storing queries to some persistence medium. | ||
| /// </summary> | ||
| public interface IStoreQueries |
There was a problem hiding this comment.
Should we rename that to IWriteStoredQueries .... just to have some symmetry between the names?
| /// <param name="queryIdentifier">The query identifier.</param> | ||
| /// <param name="query">The query to store.</param> | ||
| /// <returns>An asynchronous operation.</returns> | ||
| Task StoreQueryAsync(string queryIdentifier, IQuery query); |
There was a problem hiding this comment.
Same goes for this regarding symmetry of names.
There was a problem hiding this comment.
I originally went with IWriteStoredQueries and a method of WriteStoredQueryAsync() but something felt funny about using two words back-to-back that mean "persist". That said, I'm in no way opposed to going back to IWriteStoredQueries. I think there is still some symmetry between the interfaces in that one states "I store queries" and then the other is "I read stored queries" but it is a much looser symmetry than IRead and IWrite.
|
@willwolfram18 sorry, was completely out for the last two days. I hope I can merge the interfaces over the weekend. |
…lfram18/hotchocolate into feature/persisted-queries
|
OK, this one is done now for V10. We can add more providers with the next version. I will start on the documentation sometime tonight. |
This is a first-pass/WIP for #266 and is by no means ready for merge. I just wanted to take a crack at this and see if what's been bubbling in my head is lining up with what we might be looking for.
Since the UTF-8 parser hasn't yet been implemented, nor has the
IQueryinterface, I just stubbed one out to convey intent. Ultimately I think the read/write interfaces are just responsible for that: read/write the query given some identifier.If this looks/feels good then I'm happy to start trying to build out the other storage mediums as far as I can until we get UTF-8 parsing done (or at least started that I can work with).