Fixed deprecation handling. #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The schema serialization is now also tweaked and will not handle is deprecated as a special case anymore. Moreover, directives now do not serialize null arguments anymore. This makes the serialized schema much cleaner. |
|
OK, there were a lot of tests to update due to the schema serializer changes. But I think the printed schemas are now much nicer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation directive was not implemented as specified in the spec. With this PR we have now aligned how deprecation works with HC.
https://graphql.github.io/graphql-spec/draft/#sec--deprecated
DeprecationReasonis now obsolete. In order to be more explicit I have introducedDeprecatedfor the code-first variant.descriptor.Deprecated("reason")ordescriptor.Deprecated()can be used to deprecate a field or enum value.With code first we now are able to use
@deprecatedwithout any arguments.