Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two page spread handling #95

Open
ChiriVulpes opened this issue Apr 15, 2019 · 0 comments
Open

Two page spread handling #95

ChiriVulpes opened this issue Apr 15, 2019 · 0 comments
Labels

Comments

@ChiriVulpes
Copy link
Owner

Some pages in manga are "two-page spreads" — basically, they're two pages, but they should be stitched together into one giant image. This issue is a discussion on how Magic Translator should handle them.

1. Naming conventions

Currently, Magic Translator vol/page names must be integers, and they must all be the same number of digits; by default, two digits for vols, and three for pages. Chapters are three digits as well, but they can also have a single decimal .# at the end (this is hardcoded).

For two-page spreads, what should the page number be?

  • 002&003.png — I think if I didn't have Magic Translator, I would probably name the page something like this.

  • 002.png (no page for 003.png) — The fact that it's a "two-page spread" be incidental. If we went for this approach, I don't think Magic Translator would need to change at all, but maybe there's a good reason to not do it this way.

2. Project/volume/chapter/page buttons

The sizes of preview images are currently hardcoded to appear in portrait, at around 1:5 scale.

I'm not sure how loading a two page spread into the preview image would render it, or handle the thumbnail. I do know it wouldn't appear bigger than normal preview images, though.

How should two-page spreads look in their preview buttons?

  • Appear like a normal preview button, IE taking up the same space. This would lead to a lot of white space, since landscape images are so much shorter than portrait images.

  • Take up the space of two preview buttons. This would allow the thumbnail to appear at the same scale as normal page preview buttons, so the thumbnail would still be discernible.

Other

This is just a note for me that I need to make sure that two-page spreads work as expected in the extractor (start centred & zoomed out completely & have ability zoom to full size)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant