Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost scroll position when modal open #3043

Closed
kimsible opened this issue Aug 7, 2020 · 0 comments · Fixed by #3047
Closed

Lost scroll position when modal open #3043

kimsible opened this issue Aug 7, 2020 · 0 comments · Fixed by #3047

Comments

@kimsible
Copy link
Contributor

kimsible commented Aug 7, 2020

This PR #2962 proposed to disable the scrollbar instead of hide it but it brought one regression, when we open a modal we lose the scroll position :

issue-fixed-body gif-2
issue-fixed-body gif-1

We have 2 solutions for modals that does not impact the new disabling scrollbar UI :

  1. Do not fix the body when modal opened, so the user can still scroll the page
    issue-fixed-body-fixed-proposition

  2. Back to hide scroll-bar only when modal opened, the user will see the upload button and search input move to the right
    issue-fixed-body-fixed-proposition-2

@rigelk @Chocobozzz what solution do you prefer ? do you have another solution ?

EDIT: I myself prefer the first solution, YouTube uses this ways to display modals (not that YouTube is a great example, but for UI/UX it's a good example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant