Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Sidebar on larger (e.g. iPad-like) touch capable devices #5612

Closed
aeharding opened this issue Feb 15, 2023 · 1 comment
Closed
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion

Comments

@aeharding
Copy link

aeharding commented Feb 15, 2023

Describe the current behavior

At some point, the functionality depicted in the video from the following PR stopped working:

#3088

Now, when the sidebar is open, the content dissappears and scrolling is broken/weird (see video):

Kapture.2023-02-15.mp4

Steps to reproduce

  1. Use an iPad or a browser inspector with touch enabled (e.g. iPad in Firefox Inspector)
  2. Go to PeerTube (nightly and/or stable), open sidebar
  3. Observe content disappears and scrolling is weird

Describe the expected behavior

  • Content should have a black transparent overlay
  • Only scrolling sidebar should work.

Additional information

  • PeerTube instance: https://peertube2.cpy.re/
  • Browser: iOS iPad or iOS iPad simulator in FireFox (e.g., touch-enabled large screen device)
@Chocobozzz Chocobozzz added Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion labels Feb 16, 2023
@Chocobozzz
Copy link
Owner

Chocobozzz commented Feb 17, 2023

Thanks, I don't know why I removed these lines. Reverted in 4835b37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

No branches or pull requests

2 participants