-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multi class functionality #907
Added multi class functionality #907
Conversation
@mikebronner I opened a PR to solve this issue 2month ago. #889. But this lib doesn't seem to be maintained anymore. |
HI @Matth10, yea I saw that :) I updated additional code that your PR didn't cover. :) |
Yes this is exactly our cases. And I think I will also end up building my own one too. |
@Matth10 @mikebronner what did you guys end up with? |
@ju5t I needed up writing my own from scratch. |
This would be great functionality to add. If you are still interested in getting this merged, I think it makes more sense to require multiple classes be provided as an array instead of doing all the string splitting internally. If you aren't interested in making the change anymore just let us know. |
@mtriff Sorry, we have moved on at this point. If you would like to continue working on this PR and refining it, that would be great. |
Thanks! Implemented as part of #1166 |
Description
This PR attempts to implement allowing multi-class configs for all elements across the board.
Types of changes
Checklist