Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files copy to/from host fails if host is Windows due to incorrect filename escaping #77

Closed
schmerl opened this issue Oct 15, 2020 · 1 comment
Closed

Files copy to/from host fails if host is Windows due to incorrect filename escaping #77

schmerl opened this issue Oct 15, 2020 · 1 comment
Labels
bug Something isn't working windows

Comments

@schmerl
Copy link

schmerl commented Oct 15, 2020

When the host is windows, the shlex.quote method used to quote filenames does not work as expected. shlex is compliant only with Linux and uses single quotes. For Windows, double quotes need to be used.

The result is that if the host file name is absolute and includes the drive (.e.g, C:/SomeFile) the copy command will interpret C: as a container and will report files.Files:copy_from_host will report copying between containers is not supported
@schmerl
Copy link
Author

schmerl commented Oct 15, 2020

Related to #60

@ChrisTimperley ChrisTimperley added windows bug Something isn't working labels Oct 15, 2020
@ChrisTimperley ChrisTimperley changed the title Files copy to/from host fails if host is windows Files copy to/from host fails if host is Windows due to incorrect filename escaping Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisTimperley @schmerl