Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pympress crashes on start on Fedora 38 beta. #283

Closed
cgevans opened this issue Mar 22, 2023 · 1 comment · Fixed by #284
Closed

Pympress crashes on start on Fedora 38 beta. #283

cgevans opened this issue Mar 22, 2023 · 1 comment · Fixed by #284

Comments

@cgevans
Copy link
Contributor

cgevans commented Mar 22, 2023

Describe the bug

On the Fedora 38 beta, running Wayland and using GDK_BACKEND=wayland, Gdk.Display.get_primary_monitor returns None. As a result, ScreenArea.lookup_monitors fails, and pympress fails on startup.

There appear to be several fundamental limitations that prevent screen positioning from functioning properly with Wayland and Gtk (eg, window position information is not actually meaningful). However, changing this code to simply return something for the primary monitor will result in pympress working, with the limitation that some window positioning will not work.

To Reproduce
Steps to reproduce the behavior:

  1. Start pympress, under the conditions noted.

Environment (please complete the following information):

  • OS: Fedora 38 beta
  • Python version: 3.11.2
  • Pympress version: 1.8.0 and 8702f2e
  • Installation method: copr (release) and pip (git)
@Cimbali
Copy link
Owner

Cimbali commented Mar 22, 2023

Thanks for the report and fix. There seems to be “no concept of primary screen” on wayland which even caused gtk 4 to retire the API. I think we’ll have to parse EDID screen info in the future or something medieval like that…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants