Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Download All files from private collections #199

Closed
mkhludnev opened this issue Sep 3, 2024 · 3 comments · Fixed by #202
Closed

[BUG] - Download All files from private collections #199

mkhludnev opened this issue Sep 3, 2024 · 3 comments · Fixed by #202
Labels
bug Something isn't working

Comments

@mkhludnev
Copy link
Contributor

mkhludnev commented Sep 3, 2024

Description

Private collection hides files from non-owner, but I'm able to download files including hidden ones.

followup #177

Reproduction steps

1. Crete private collection
2. Upload file into private collection
3. Logout, login another user (non-admin)
4. Go to Files, select that private collection
5. There is no files visible since collection is private 1. and user has been changed 4.
6. Click Download all files 

# Expect
No files, or error, or unable to click

# Actual 
Got all files in archive

Screenshots

Screenshot from 2024-09-03 13-27-56

Logs

No response

Browsers

Firefox

OS

Linux

Additional information

No response

@mkhludnev mkhludnev added the bug Something isn't working label Sep 3, 2024
@mkhludnev
Copy link
Contributor Author

If you confirm it I would like to come up with PR.

@taprosoft
Copy link
Collaborator

Confirm this is unwanted behavior.

@mkhludnev
Copy link
Contributor Author

The fix disabled dowloadAll for private collection. Fair. I'll try to request download a file which a user has no access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants