Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-promote-prod-from-git-tag orb job should allow for user provided versions #116

Closed
ebellefontaine opened this issue Jul 20, 2021 · 0 comments · Fixed by #111
Closed

Comments

@ebellefontaine
Copy link

ebellefontaine commented Jul 20, 2021

One of the difficulties I have been facing with the orb-tools dev-promote-prod-from-git-tag job is that I use release-it to generate my github releases, and create git tags and have that integrated into my workflows.

It would be nice to be able to provide a parameter to the dev-promote-prod-git-tag job to allows the user to provide their own version

Example:

...
workflows:
   release:
      jobs:
        - create-release: # Calls Release-it to generate github release, and git tag
            filters:
              branches:
                only: master
              tags:
                ignore: /.*/
   deploy:
      jobs:
        - orb-tools/dev-promote-prod-from-git-tag:
            orb-name: <my-org>/<my-orb>
            add-pr-comment: false
            version: ${CIRCLE_TAG} # <-- Something like this
            filters:
              tags:
                only:
                  - /^v*[0-9]+.[0-9]+.[0-9]+$/
              branches:
                ignore: /.*/
@KyleTryon KyleTryon linked a pull request Mar 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant