Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian and Alpine built with the same tags #5

Closed
avishefi opened this issue Nov 30, 2022 · 6 comments
Closed

Debian and Alpine built with the same tags #5

avishefi opened this issue Nov 30, 2022 · 6 comments

Comments

@avishefi
Copy link

The Jenkinsfiles look the same, and there are no different tags on Docker Hub for either Alpine or Debian.

@barborico
Copy link

+1
The Jenkinsfiles for debian specifically pull the alpine Dockerfiles and scripts; see e.g.

cp -r clamav-docker/clamav/${params.FEATURE_VERSION}/alpine/Dockerfile clamav-docker/clamav/${params.FEATURE_VERSION}/alpine/scripts .
.

@JonBendtsen
Copy link
Contributor

Attempted to fix in #11, but I'm just a regular user as well, so who knows if my proposed fix is okay and when it might or might not be approved.

@val-ms
Copy link
Collaborator

val-ms commented Jan 4, 2023

Thanks for the fix to the Jenkinsfiles @JonBendtsen. That was indeed an issue,

Right now we have Jenkinsfiles and supporting scripts for Debian, but we aren't yet building or publishing them. That's still a work in progress. When it's stable, we'll publish them to https://registry.hub.docker.com/r/clamav/clamav-debian (clamav/clamav-debian).

Until then, the only images we publish (at clamav/clamav) are based on Alpine.

Some day, I think we may switch the main image from Alpine to Debian as well. But we don't have a specific date in mind. We'll have to schedule and announce the plans to the ClamAV community far in advance to make sure that goes smoothly.

@avishefi
Copy link
Author

avishefi commented Jan 5, 2023

@micahsnyder I see #11 is merged, can't we use it to create additional tags on clamav/clamav?

@val-ms
Copy link
Collaborator

val-ms commented Jan 5, 2023

@micahsnyder I see #11 is merged, can't we use it to create additional tags on clamav/clamav?

We don't publish debian-based images to clamav/clamav yet, so that wouldn't make any sense. We ought to start publishing them to clamav/clamav-debian as I mentioned yesterday. With the fix you made I think it may be good to go. .

@rsundriyal
Copy link
Contributor

As per the last merge #33, we now publish separate image tags for the Alpine and Debian images.

Please go through the README.md for more details about images/repos/tags.

As the issue is now obsolete, I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants