This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Consul DNS Package #1232
Merged
Consul DNS Package #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
provisioned on top of 1.0.3 rc1 AWS cluster. installed cleanly, no problems so far |
|
Looks like the build failed, but because Docker hub timed out on one cloud. The others worked fine. Should we consider that a green or retry it? @sehqlr |
|
I would say retry it once. |
|
Right, I'll rebase and then we can get this merged! 👍 |
|
As of right now, it would be a fast-forward merge. So we're good here. |
| path: /etc/NetworkManager/dnsmasq.d | ||
| state: directory | ||
| command: sed -i'' 's/consul *//g' /etc/resolv.conf.masq | ||
| register: resolve_without_consul |
There was a problem hiding this comment.
is this used for anything? (the resolve_without_consul variable)
There was a problem hiding this comment.
just an old line I forgot to remove. Thanks for catching it!
|
lgtm, successfully tested on aws. automated digitalocean build failed due to unrelated problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1230