This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
pull request template: remove rebase requirement #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should still be a requirement, but it's not helpful to have in the template because it can't really be evaluated until after all discussion and testing is finished. Having another box to check also means that in Github's UI there are a lot of issues that have 3/4 requirements checked where the fourth is the rebase requirement, and which are otherwise completely ready for merge.
|
lgtm |
ryane
added a commit
that referenced
this pull request
Mar 11, 2016
pull request template: remove rebase requirement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should still be a requirement, but it's not helpful to have in the template because it can't really be evaluated until after all discussion and testing is finished. Having another box to check also means that in
Github's UI there are a lot of issues that have 3/4 requirements checked where the fourth is the rebase requirement, and which are otherwise completely ready for merge.