Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

[WIP]: Feature/docker refactor #1278

Closed
wants to merge 15 commits into from
Closed

Conversation

stevendborrelli
Copy link
Contributor

Hi, thank you for your contribution to Mantl! Before we can accept any code into
master, we need it to meet the following criteria. If there are any you can't
satisfy yourself, go ahead and open the pull request anyway and we'll help you
test. Feel free to delete this message once you're done. Thanks again!

  • Installs cleanly on a fresh build of most recent master branch
  • Upgrades cleanly from the most recent release
  • Updates documentation relevant to the changes

This refactors the docker implementation:

  • can either install docker inc rpms or the redhat package
  • allows multiple docker options
  • configurable logging backend (defaulting to journald)
  • redo storage to use mantl-storage-setup, this removes a lot of the ansible code

@avnik
Copy link
Contributor

avnik commented Mar 15, 2016

Looks good on first glance.
Need some minor tweaking regarding storage setup, but I'll done it, when prepare my storage-setup branch to merge

@stevendborrelli stevendborrelli added this to the 1.1 milestone Mar 15, 2016
@stevendborrelli
Copy link
Contributor Author

Closing this, as we'll have a newer PR that includes updated storage.

@stevendborrelli stevendborrelli deleted the feature/docker-refactor branch April 25, 2016 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants