This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
patch use builtin vsphere provider #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look fine. I left a comment on the docs. Part of the docs may be referring to a bug that exists in the provider. The provider is not waiting for vsphere to provision the ip addresses. |
|
Seems the issue is in /builtin/providers/vsphere/resource_vsphere_virtual_machine.go. Guest.Net is of type GuestNicInfo which gets filled in with the vmware/govmomi/list/lister.go |
|
Sweet, thanks to both of you for the PR and the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works against ESXi 6.0, template needs to have the latest VMware tools installed, or else the customization will not work.