Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

update kubelet hostname override #1376

Merged
merged 2 commits into from
May 3, 2016
Merged

update kubelet hostname override #1376

merged 2 commits into from
May 3, 2016

Conversation

ryane
Copy link
Contributor

@ryane ryane commented Apr 22, 2016

  • Installs cleanly on a fresh build of most recent master branch
  • Upgrades cleanly from the most recent release
  • Updates documentation relevant to the changes

This or #1374 is sufficient to fix at least one of the problems in #1367 but both together is probably better.

@ryane ryane added this to the 1.1 milestone Apr 22, 2016
@ryane ryane mentioned this pull request Apr 22, 2016
@BrianHicks
Copy link
Contributor

Did you just not mark the "upgrade" because you're not sure? Because it looks like that'd upgrade just fine to me.

@ryane
Copy link
Contributor Author

ryane commented Apr 22, 2016

Yeah, I tend to only mark it if I actually tested it but that's probably not sustainable. I agree, it looks like it will upgrade ok

@andreimc
Copy link
Contributor

@ryane I will test this fix on vagrant later today let you know if it fixes the issue

@andreimc
Copy link
Contributor

@ryane still getting 502 with this merged in.
screen shot 2016-04-23 at 12 19 10 pm

@andreimc
Copy link
Contributor

I get the following

TASK: [kubernetes-addons | create or update dashboard] ************************
failed: [control-01] => {"failed": true}
msg: error running kubectl (/bin/kubectl --server=http://localhost:8085/ --namespace=kube-system create --filename=/etc/kubernetes/manifests/kubernetes-dashboard.yaml) command (rc=1): replicationcontroller "kubernetes-dashboard" created

FATAL: all hosts have already failed -- aborting

@sehqlr sehqlr self-assigned this May 3, 2016
@sehqlr sehqlr merged commit 4f6554f into master May 3, 2016
@sehqlr
Copy link
Contributor

sehqlr commented May 3, 2016

I tested this on AWS and Vagrant. LGTM

@langston-barrett langston-barrett deleted the fix/kubelet-hostname branch May 3, 2016 23:43
@distributorofpain
Copy link

distributorofpain commented May 8, 2016

Not sure if this is related, but i just deployed a fresh deployment to Digital Ocean ( no errors ). Freshly built command server with latest centos 7.2 image. Consul shows kubernetes all green, but when i try to launch the UI i get 404 not found from nginx/1.6.2 . All other aspects of mantl are working properly.

i should note that i set kubeworker_count = 0 in the terraform.tf file being used for deployment.

@ryane ryane unassigned sehqlr Nov 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants