This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
aws: gp2 volume type for root device #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated the aws terraform instance root volumes to use the gp2 type by default * configurable for root and attached volumes * however, without manual configuration, the options are effectively limited to `standard` and `gp2` due to terraform limitations. The `io1` requires specifying `iops` on each volume but that setting is not compatible with the other types and cannot currently be conditionally included. If you want to set `io1`, you will also need to update `terraform/aws/instance/main.tf` to specify the `iops` attribute on the specific volume(s).
|
Fixes #1414 |
|
aws build failed due to quota. |
|
@ryan are we good to merge this one? |
|
I've been using it successfully on aws. as long as it looks good to you, it can be merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default
standardandgp2due to terraform limitations. Theio1requires specifyingiopson each volume but that setting is not compatible with the other types and cannot currently be conditionally included. If you want to setio1, you will also need to updateterraform/aws/instance/main.tfto specify theiopsattribute on the specific volume(s).terraform/aws/aws.tfterraform with this option.