Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Include docker-cleanup rpm package by default, with appropriate settings. #831

Closed
sehqlr opened this issue Nov 19, 2015 · 7 comments
Closed
Assignees
Milestone

Comments

@sehqlr
Copy link
Contributor

sehqlr commented Nov 19, 2015

As of right now, we have a rpm package for docker-cleanup, but it is not installed by default. We need to include the install as well as appropriate exclusion settings. For example, zookeeper keeps data in a volume that could be collected, and break things. (Thanks for pointing this out, @ryane). Testing needs to be done to make sure that this doesn't happen.

@stevendborrelli, is this something that we need to include in 0.5? What do you think?

@stevendborrelli
Copy link
Contributor

Yes, it should be part of the docker role.

@eirslett
Copy link
Contributor

The zookeeper case could probably be solved by moving zookeeper out of docker? #765

@stevendborrelli
Copy link
Contributor

@eirslett we're planning on refactoring zk, but it won't make it for the 0.5 release.

@sehqlr sehqlr self-assigned this Nov 23, 2015
@sehqlr
Copy link
Contributor Author

sehqlr commented Nov 23, 2015

I've tested my changes for excluding the zookeeper data volume from cleanup, and it works as expected. Are there other volumes that need to be excluded, or is this a go for a PR?

@stevendborrelli
Copy link
Contributor

Yes. Update this ticket with the PR.

@sehqlr
Copy link
Contributor Author

sehqlr commented Nov 23, 2015

PR #861 is ready for testing

@stevendborrelli stevendborrelli modified the milestones: Feature Backlog, 0.6 Feb 1, 2016
@stevendborrelli stevendborrelli modified the milestones: 1.1, Feature Backlog Apr 19, 2016
@stevendborrelli
Copy link
Contributor

Closing this due to docker-gc installation.

@stevendborrelli stevendborrelli changed the title Include docker-cleanup rpm package by default, with appropriate settings. Include docker-cleanup rpm package by default, with appropriate settings. Apr 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants