Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Date Formats flipped for most fields #7

Open
Prajna1999 opened this issue Dec 10, 2024 · 1 comment
Open

[BUG] Date Formats flipped for most fields #7

Prajna1999 opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Prajna1999
Copy link
Collaborator

According to OCDS specifications, all dates should be formatted as YYYY-MM-DDT00:00:00Z.

In the current version of public facing data all dates should be already formatted like this, but that was not addressed in the main data transformation script, but rather in additional bash scripts. Prior to next release we need to ensure that all dates are formatted correctly in the main data transformation script.

Currently there are a couple of different formats in use (examples provided not from public facing data, but from the draft data)

date: 2023-10-19
tendrer/datePublished: 2017-29-04 12:00
tender/tenderPeriod/startDate: 2017-29-04 12:00
tender/tenderPeriod/endDate: 2017-29-05 14:00
tender/communication/documentAvailabilityPeriod/startDate: 2017-30-04 12:00
tender/communication/documentAvailabilityPeriod/endDate: 2017-29-05 14:00
tender/bidOpening/date: 2017-29-05 14:00
tender/enquirePeriod/startDate: 2017-13-06 14:00
tender/enquirePeriod/endDate 2017-16-06 12:00
tender/milestones/dueDate: 2017-20-04 14:00
tender/amendments/date: 2018-18-06 16:05
bids/details/date: 2017-20-04 13:53
awards/contractPeriod/startDate: I don't have the latest format here, but probably it is the same as the most dates

As you can see, in most of this cases, date and month parts of the date object are swapped, so that's an additional issues that should be addressed during the formatting.

If there's need we can also document how date looks like in the source (scraped) data. That might provide better understanding of how this issue can be addressed.

@Prajna1999
Copy link
Collaborator Author

@AakashGandhi1 for now write a simple python/bash script to fix the thing and refactor/rewrite into the new repo

@Prajna1999 Prajna1999 added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants