Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@class='cl', @role='cl' #38

Open
jonathanrobie opened this issue Jul 28, 2022 · 0 comments
Open

@class='cl', @role='cl' #38

jonathanrobie opened this issue Jul 28, 2022 · 0 comments

Comments

@jonathanrobie
Copy link
Contributor

jonathanrobie commented Jul 28, 2022

We currently have a top-level node in each sentence that has role="cl", as opposed to class="cl" in lower nodes. This is confusing to many.

<wg role="cl">
         <wg class="cl" rule="P2CL" cltype="Verbless" xml:id="400010010010082">

Some ways we could fix this:

  1. Delete the attribute from the topmost node, or
  2. Come up with a meaningful attribute name, or
  3. Delete the node itself

I favor #1, just deleting the attribute, which gives us:

   <sentence>
      <p>
         <milestone unit="verse" id="MAT 1:1">MAT 1:1</milestone> 
         Βίβλος γενέσεως Ἰησοῦ Χριστοῦ υἱοῦ Δαυεὶδ υἱοῦ Ἀβραάμ.
      </p>
      <wg>
         <wg class="cl" rule="P2CL" cltype="Verbless" xml:id="400010010010082">

In my sandbox, I did that with this XQuery:

for $node in //sentence/wg
return delete node $node/@role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant