Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back ammunition explosions as a special effect. #25031

Closed
kevingranade opened this issue Aug 21, 2018 · 0 comments · Fixed by #37399
Closed

Bring back ammunition explosions as a special effect. #25031

kevingranade opened this issue Aug 21, 2018 · 0 comments · Fixed by #37399
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Good First Issue This is a good first issue for a new contributor Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter

Comments

@kevingranade
Copy link
Member

Is your feature request related to a problem? Please describe.
#24862 addressed the most pressing issue in #24788 of lethal exploding small arms ammunition, but removed the special effect of exploding ammunition, which aids imersiveness and provides an opportunity for manipulating the environment (such as by causing a distraction).

Describe the solution you'd like
Re-add the explosion, but with a very minimal magnitude, similar to a firecracker (especially, with no shrapnel).

Describe alternatives you've considered
Instead of exploding, it could simply cause a noise and destroy the ammunition, but since that's exactly what the explosion code does when properly tuned, it seems unnecessary.
@kevingranade kevingranade added <Enhancement / Feature> New features, or enhancements on existing Good First Issue This is a good first issue for a new contributor [C++] Changes (can be) made in C++. Previously named `Code` (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Aug 21, 2018
@Inglonias Inglonias mentioned this issue May 30, 2019
Closed
@SeventhSandwich SeventhSandwich mentioned this issue Jan 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Good First Issue This is a good first issue for a new contributor Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow ammunition to burn and make small explosions with loud sounds SeventhSandwich/Cataclysm-DDA
1 participant
@kevingranade