Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle-mounted turrets always shoot from driver's seat instead of their own place #39557

Closed
GGgatherer opened this issue Apr 14, 2020 · 3 comments · Fixed by #40198
Closed
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions

Comments

@GGgatherer
Copy link
Contributor

Describe the bug

When trying to shoot a turret (or when it shoots on autotarget) source point of the shot is driver's seat, not the actual turret emplacement.

Steps To Reproduce

Make a vehicle, install a turret anywhere but driver seat(where vehicle controls are), try shooting it, see where cursor points from.

Expected behavior

Turrets shooting from the places at which they actually reside.

Versions and configuration

  • OS: Windows 7x64
  • Game Version: 0.E-635-gef0197a [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Modular Turrets [modular_turrets],
    Salvaged Robots [Salvaged_Robots],
    Aftershock [aftershock],
    Alternative Map Key [alt_map_key],
    sees-player icon, retrodays [sees_player_retro],
    Stats Through Skills [StatsThroughSkills],
    Magiclysm [magiclysm]
    ]

Additional context

Different from #39445, but military vehicles have armored walls in most directions from driver's seat, so it is probably 2 sides of 1 ugly coin.

Also, seems to be a resurfacing of #22512.

@olanti-p
Copy link
Contributor

olanti-p commented Apr 17, 2020

Actually, this is just a visual bug.
Aiming interface always draws trajectory from the player's position to where they aim at; when actually firing, each turret calculates its own trajectory and fires from its own position. Unless that was changed in the last 2 months...

I'll look into fixing this one

@GGgatherer
Copy link
Contributor Author

Are you absolutely sure about that? Because I could swear turrets were previously showing bullet trajectory originating from their own tiles.

@olanti-p
Copy link
Contributor

olanti-p commented Apr 23, 2020

They still do. Here's me shooting a turret from vehicle controls:
cdda_fire
You can see the bullets coming out of the turret and destroying the wall, despite target selection UI drawing the line from your seat. Unless you meant something else?

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions labels Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants