Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electric chainsaw, too high energy drain and behaves unrealistically. #39560

Closed
ampersand55 opened this issue Apr 14, 2020 · 4 comments
Closed
Labels
Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@ampersand55
Copy link
Contributor

Describe the bug

  1. Electric chainsaw drains 750-800 battery per use. It comes with a medium battery (500) so you immediately run out of charges after using it once. See Electric tools' energy drain is much higher than possible #32503.
  2. Electric chainsaw should not draw power constantly like a gasoline powered chainsaw, only when you use it. See Electric Chainsaws drain batteries after just one cut #35203.

Steps To Reproduce

Make a survivor, spawn an electric chainsaw, use it.

Additional context

I was working on what I thought was an easy fix, but I encountered some problems related to using chainsaw as a weapon.

See master...ampersand55:fix_electric_chainsaw

This fixes both problems outlined in the description, but it introduces new problems with using chainsaw as a weapon.

My first idea was to make "chainsaw_on" a "weapon mode", and have that draw power continuously over time. The problem is that it draws "charges_per_use" when you activate it (i.e. turns it into weapon mode) which is set to 1/4 of its total charge. It also makes it inconsistent with "electric combat chainsaw" and "electric chainsaw lajatang".

Some random brainstorming ideas:

  1. make some c++ changes to allow use_action to not consume charges.
  2. to remove the usage of the "electric chainsaw" as a weapon entirely, and require a conversion to an "electric combat chainsaw" for use as a weapon
  3. make it a ranged weapon with range 1 and have it consume battery "ammo" as you use it.
  4. remove all the chainsaw weapons entirely.
  5. accept the initial activation cost for switching to "weapon mode".

Btw, "electric combat chainsaw" only has ~3 minutes of use. Regular "combat chainsaw" has 30 minutes of use. Is this an oversight?

Sorry for the mess of an issue.

@mrkybe
Copy link
Contributor

mrkybe commented Apr 14, 2020

Btw, "electric combat chainsaw" only has ~3 minutes of use. Regular "combat chainsaw" has 30 minutes of use. Is this an oversight?

Gasoline is far more energy dense than batteries. Not sure about the weight proportions between the two chainsaws though.

@ampersand55
Copy link
Contributor Author

True, but electric chainsaws tend to have larger batteries to make up for that.

I think the main problem is that we assume the chain saws running at full effect for the entire duration. This is rarely the case, and electric motors don't have any energy drain when idle. You could argue that they should be on constant max effect when being used in e.g. "electric chainsaw lajatangs". But not in normal tool usage. It's hard to balance tool use and weapon use, which is my main point.

The electric chain saw has a "power_draw" of 2000000 mW, i.e. 2 kW, which is consistent with my calculations from the previous issue:

This chain saw:

... has a listed "operating time" of 15 minutes with a AP 100 battery, which should only be 2m 48s at max effect.

@Night-Pryanik Night-Pryanik added <Suggestion / Discussion> Talk it out before implementing Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact labels Apr 17, 2020
@stale
Copy link

stale bot commented May 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label May 17, 2020
@stale
Copy link

stale bot commented Jun 16, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants