Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code support for ammo effects on explosions. #39611

Closed
Brian-Otten opened this issue Apr 16, 2020 · 3 comments
Closed

Code support for ammo effects on explosions. #39611

Brian-Otten opened this issue Apr 16, 2020 · 3 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.

Comments

@Brian-Otten
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I've been working on the explosives system and have finished up most of the conventional explosives and was moving on to an attempt to make firebombs work. It seems right now the one firebomb we have right now is the molotov, which is hardcoded, and thus not extensible to making more.

Describe the solution you'd like

The most straightforward approach to me seemed to have code support to call for an ammo effect when a bomb explodes. The ammo effects are fully jsonized and people will then be able to add in new bombs and their effects trivially.

There might be a neater way to jsonize which would also be 100% okay.

If someone would be willing to do the work on making it possible i could then make a variety of firebombs for the player to craft.
@natsirt721
Copy link
Contributor

natsirt721 commented Apr 16, 2020 •
edited
Loading

What about the incendiary grenade?

@weekly-digest weekly-digest bot mentioned this issue Apr 19, 2020
Closed
@KorGgenT KorGgenT added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Apr 26, 2020
@stale
Copy link

stale bot commented May 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label May 26, 2020
@stale
Copy link

stale bot commented Jun 25, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@natsirt721 @KorGgenT @Brian-Otten