[magiclysm] Repeat castings of Aura of protection results in 'no hands free'

[Resok]

Describe the bug

Currently the first casting works as expected, auto-wearing an aura. However casters after the first are instead added to your inventory, up until a point where you can no longer store them and they're instead wielded in two hands.

Steps To Reproduce

1. Start a new character
2. Learn aura of protection
3. Cast aura of protection
4. Cast aura of protection again

'Aura' item is either generated in your inventory or held in your hands if no inventory room is available.

Expected behavior

Aura of protection that is currently 'worn' by the player should instead be refreshed with a new duration, or removed (and destroyed) and replaced by the newly created aura with a fresh duration.

Alternatively each subsequent casting could increase the duration of the existing aura by the amount, allowing you to 'empower' the aura to a longer duration with enough mana.

Either of these options would allow for repeated castings of the spell without the oddities of having a bunch of extra items created in the world.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0 1909
• Game Version: 0.E-1778-g781ca2e [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Magiclysm [magiclysm]
  ]

Additional context

I'm not sure if this issue existed before the major updates to inventory or not.

[jeremyshannon]

I kinda thought this was a feature, the second one appearing in your hands means you can get your NPCs to wear it, allowing you to place an aura around several NPCs if you're willing to spend the time and mana. They are still unremovable once worn and vanish at the end of their duration.
It definitely feels weird and magical.

[Resok]

I think if it was intentional behavior to be able to cast the aura on others then it would be ranged targetable like bless right? Maybe a decent solution would be to make it ranged targetable? Dunno. Many options, each with their own pros and cons.

[KorGgenT]

taking a glance at the summary of this bug i'm still not sure what the best result of this should be. the only thing i can think of at the moment is disallowing casting the item summon spell if it has the flag that makes it impossible to take off and you are already wearing two copies.