Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary null pointer checks #8416

Closed
elfring opened this issue Aug 3, 2014 · 2 comments · Fixed by #8545
Closed

Remove unnecessary null pointer checks #8416

elfring opened this issue Aug 3, 2014 · 2 comments · Fixed by #8545

Comments

@elfring
Copy link

elfring commented Aug 3, 2014

An extra null pointer check is not needed in functions like the following.
@BevapDin
Copy link
Contributor

BevapDin commented Aug 3, 2014

Even better: transform those members into std::unique_ptr and you can remove the deletion completely. Or in case of the overmap make it a std::array.

This was referenced Aug 11, 2014
Merged
Merged
@elfring
Copy link
Author

elfring commented Aug 13, 2014

Thanks for your small source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfixes BevapDin/Cataclysm-DDA
2 participants
@elfring @BevapDin