Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClimaAtmos doesn't compile on Julia 1.11-rc1 #3186

Closed
Sbozzolo opened this issue Jul 10, 2024 · 1 comment
Closed

ClimaAtmos doesn't compile on Julia 1.11-rc1 #3186

Sbozzolo opened this issue Jul 10, 2024 · 1 comment

Comments

@Sbozzolo
Copy link
Member

Consider the minimum working example

import ClimaAtmos as CA
config = CA.AtmosConfig()
params = CA.create_parameter_set(config)

atmos = get_atmos(config, params); # This takes forever

Taking forever means that I've never seen it compile, but if I strip the function down, e.g. commenting some entries in AtmosModel in get_atmos:

    atmos = AtmosModel(;
        moisture_model,
        model_config,
        radiation_mode,
        subsidence = get_subsidence_model(parsed_args, radiation_mode, FT),
        ls_adv = get_large_scale_advection_model(parsed_args, FT),
        external_forcing = get_external_forcing_model(parsed_args),
        edmf_coriolis = get_edmf_coriolis(parsed_args, FT),
        advection_test,
        tendency_model = get_tendency_model(parsed_args),
        edmfx_entr_model,
        edmfx_detr_model,
        edmfx_sgs_mass_flux,
        edmfx_sgs_diffusive_flux,
        edmfx_nh_pressure,
        edmfx_filter,
        precip_model,
        cloud_model,
        forcing_type,
        call_cloud_diagnostics_per_stage,
        # turbconv_model = get_turbconv_model(FT, parsed_args, turbconv_params),
        # non_orographic_gravity_wave = get_non_orographic_gravity_wave_model(
        #     parsed_args,
        #     model_config,
        #     FT,
        # ),
        # orographic_gravity_wave = get_orographic_gravity_wave_model(
        #     parsed_args,
        #     FT,
        # ),
        # hyperdiff = get_hyperdiffusion_model(parsed_args, FT),
        vert_diff,
        # diff_mode = implicit_diffusion ? Implicit() : Explicit(),
        # sgs_adv_mode = implicit_sgs_advection ? Implicit() : Explicit(),
        # viscous_sponge = get_viscous_sponge_model(parsed_args, params, FT),
        # rayleigh_sponge = get_rayleigh_sponge_model(parsed_args, params, FT),
        # sfc_temperature = get_sfc_temperature_form(parsed_args),
        # insolation = get_insolation_form(parsed_args),
        # surface_model = get_surface_model(parsed_args),
        # surface_albedo = get_surface_albedo_model(parsed_args, params, FT),
        numerics = get_numerics(parsed_args),
    )

This compiles in 2 minutes. It takes almost no time on Julia 1.10

@Sbozzolo
Copy link
Member Author

Fixed in Julia 1.11-rc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant