Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O2.6.4 Spatially varying parameters - Canopy model #596

Closed
1 of 4 tasks
kmdeck opened this issue Apr 26, 2024 · 0 comments · Fixed by #863
Closed
1 of 4 tasks

O2.6.4 Spatially varying parameters - Canopy model #596

kmdeck opened this issue Apr 26, 2024 · 0 comments · Fixed by #863
Assignees
Labels
SDI Software Design Issue

Comments

@kmdeck
Copy link
Member

kmdeck commented Apr 26, 2024

Purpose

To introduce code that allows us to set up spatially varying parameters which do not vary in time in the canopy model, and make use of them throughout the simulation. This will use the spatially varying parameter framework put in place by the completion of #126 and used to supply spatially varying parameters to the soil model by #485.

Cost/benefits/risks

  • Costs:
    • Developer hours
    • Will require simplification of the canopy hydraulics model which will cost us the ability to set up multilayered canopy hydraulics
  • Benefits:
    • Provide a clean interface for varying parameters for the canopy model spatially
    • Unifies the way we handle spatially varying parameters for the canopy model regardless of the simulation domain.
  • Risks:
    • Could potentially result in performance issues for the canopy model.

Producers

Components

  • Simplification of the PlantHydraulics model to run only for the case of a big leaf model, without multiple layers to reduce data stored across space
  • Creation of a biomassModel submodule in the canopy
  • Refactoring of the canopy to place all relevant biomass parameters within the new biomass model
  • Integration of the SpaceVaryingInput function mechanism used in the soil model

Results and deliverables

  • Canopy model running over spatially varying parameters
  • A tutorial demonstrating how to set up a canopy run with parameters varying across space
  • A series of tests verifying the canopy behavior when set up to vary spatially
  • A test to verify that the single layered plant hydraulics model produces the same output as the previous multilayered model for the case of a single layer

Task breakdown

A preliminary list of PRs and a preliminary timeline of PRs, milestones, and key results.

Reviewers

@kmdeck kmdeck added the SDI Software Design Issue label Apr 26, 2024
@kmdeck kmdeck changed the title Spatially varying parameters - Canopy model O2.6.4 Spatially varying parameters - Canopy model Apr 26, 2024
@kmdeck kmdeck mentioned this issue Jul 2, 2024
36 tasks
@Espeer5 Espeer5 linked a pull request Oct 19, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDI Software Design Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants