Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps; use CTS v0.8; tag v0.15.9 #996

Merged
merged 2 commits into from
Jan 30, 2025
Merged

update deps; use CTS v0.8; tag v0.15.9 #996

merged 2 commits into from
Jan 30, 2025

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Jan 29, 2025 •
edited
Loading

Purpose

update dependencies, notably to use ClimaTimeSteppers v0.8.1

removes ImplicitEquationJacobian and uses ClimaCore.MatrixFields.FieldMatrixWithSolver instead

tag biweekly patch release

package changes in .buildkite/ environment

    Updating `~/clima/ClimaLand.jl/.buildkite/Project.toml`
  [4c88cf16] ↑ Aqua v0.8.9 ⇒ v0.8.10
  [3a4d1b5c] ↑ ClimaComms v0.6.5 ⇒ v0.6.6
  [d414da3d] ↑ ClimaCore v0.14.22 ⇒ v0.14.24
  [595c0a79] ↑ ClimaTimeSteppers v0.7.38 ⇒ v0.8.1
  [b3f4f4ca] ↑ ClimaUtilities v0.1.20 ⇒ v0.1.21
⌅ [587475ba] ↓ Flux v0.15.2 ⇒ v0.14.25
  [0bca4576] ↑ SciMLBase v2.71.0 ⇒ v2.72.1
  [90137ffa] ↑ StaticArrays v1.9.10 ⇒ v1.9.11

@juliasloan25 juliasloan25 mentioned this pull request Jan 29, 2025
Merged
@juliasloan25 juliasloan25 changed the title update deps; use CTS v0.8.1 update deps; use CTS v0.8; tag v0.15.9 Jan 30, 2025
@Sbozzolo
Copy link
Member

I think the best way to fix this is by using the ClimaCore FieldMatrixWithSolver (https://github.com/CliMA/ClimaCore.jl/blob/c722d5ec0aa1bcee83579f3296ad03fecc8146c9/src/MatrixFields/field_matrix_with_solver.jl#L13) instead of our own.

@juliasloan25 juliasloan25 merged commit eb656c7 into main Jan 30, 2025
16 checks passed
@juliasloan25 juliasloan25 deleted the js/ctsv080 branch January 30, 2025 23:23
Sbozzolo added a commit that referenced this pull request Feb 4, 2025
@Sbozzolo
Bump ClimaTimeSteppers in ClimaLandSimulations
e0e1aa9 
This was missed in #996
@Sbozzolo Sbozzolo mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

@AlexisRenchon AlexisRenchon Awaiting requested review from AlexisRenchon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliasloan25 @Sbozzolo