You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we need a PR focused on cleaning up some of the legacy constructors out there before the code gets used by others.
In particular I'd like to work on #413 (currently on the grid-xyz branch) which involves refactoring the RegularCartesianGrid constructor and I'd rather not leave behind three legacy constructors.
Also, I'm not a fan of the BasicModel constructor. I understand it was introduced to avoid refactoring all the Model constructors, but would be nice to get rid of it.
The text was updated successfully, but these errors were encountered:
I think we need a PR focused on cleaning up some of the legacy constructors out there before the code gets used by others.
In particular I'd like to work on #413 (currently on the
grid-xyz
branch) which involves refactoring theRegularCartesianGrid
constructor and I'd rather not leave behind three legacy constructors.Also, I'm not a fan of the
BasicModel
constructor. I understand it was introduced to avoid refactoring all theModel
constructors, but would be nice to get rid of it.The text was updated successfully, but these errors were encountered: