Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy constructors #429

Closed
ali-ramadhan opened this issue Sep 27, 2019 · 1 comment · Fixed by #496
Closed

Clean up legacy constructors #429

ali-ramadhan opened this issue Sep 27, 2019 · 1 comment · Fixed by #496
Labels
cleanup 🧹 Paying off technical debt
Milestone

Comments

@ali-ramadhan
Copy link
Member

I think we need a PR focused on cleaning up some of the legacy constructors out there before the code gets used by others.

In particular I'd like to work on #413 (currently on the grid-xyz branch) which involves refactoring the RegularCartesianGrid constructor and I'd rather not leave behind three legacy constructors.

Also, I'm not a fan of the BasicModel constructor. I understand it was introduced to avoid refactoring all the Model constructors, but would be nice to get rid of it.

@ali-ramadhan ali-ramadhan added the cleanup 🧹 Paying off technical debt label Sep 27, 2019
@ali-ramadhan ali-ramadhan added this to the JOSS milestone Sep 27, 2019
@ali-ramadhan
Copy link
Member Author

I'd also like to introduce a single time_step! function

time_step!(model; Δt, Nt=1)

and get rid of the "legacy" time_step! functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant