Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to support dbt-core v1.6.0 #164

Closed
2 of 6 tasks
dataders opened this issue Jun 29, 2023 · 4 comments · Fixed by #215
Closed
2 of 6 tasks

upgrade to support dbt-core v1.6.0 #164

dataders opened this issue Jun 29, 2023 · 4 comments · Fixed by #215
Assignees

Comments

@dataders
Copy link

dataders commented Jun 29, 2023

Background

Minor version v1.6 is targeted for final release on July 27, 2023. As a maintainer of a dbt adapter, we strongly encourage you to release a corresponding minor version increment to ensure users of your adapter can make use of this new minor version.

How to upgrade

dbt-labs/dbt-core#7958 is an open discussion with more detailed information. If you have questions, please put them there!

The above linked guide has more information, but below is a high-level checklist of work that would enable a successful 1.6.0 release of your adapter:

Tasks

Preview Give feedback

the next minor release: 1.7.0

FYI, dbt-core==1.7.0 is expected to be released on October 12, 2023 in time for Coalesce, the annual analytics engineering conference!

@zli06160
Copy link
Contributor

Is there anyone working on the upgrade?

I had an issue few days ago, i would use dbt-core>=1.4.8 under the constraint:
-c https://raw.githubusercontent.com/apache/airflow/constraints-2.6.3/constraints-3.11.txt

So the upgrade is necessary.
c.c. @genzgd @gfunc

@dataders
Copy link
Author

@zli06160 I think this might be related to dbt-labs/dbt-snowflake#687 (comment)

@zli06160
Copy link
Contributor

zli06160 commented Oct 11, 2023

@dataders Thanks a lot for the investigation! It solved half of my problem.

Actually dbt-clickhouse==1.4.8 worked perfectly with the constraint file https://raw.githubusercontent.com/apache/airflow/constraints-2.5.1/constraints-3.10.txt

But for https://raw.githubusercontent.com/apache/airflow/constraints-2.6.3/constraints-3.11.txt and/or dbt-core>=1.6.0 there are still some works(e.g. the nested dependancies...) to do.

Of course, there is no more need to follow the constraint file line by line.

@genzgd genzgd self-assigned this Nov 24, 2023
@genzgd
Copy link
Contributor

genzgd commented Nov 25, 2023

Just a heads up for folks watching this issue -- the dbt-core implementation for materialized views is very PostgreSQL specific and is not compatible with ClickHouse Materialized views. The initial 1.6.0 release of dbt-clickhouse will accordingly not include MV support.

In particular, a PostgreSQL (or Oracle) MV is static, containing the data from a SELECT query at the time the MV is created. This static data can be "REFRESHed" with a SQL query. ClickHouse MVs are equivalent to standard SQL "INSERT TRIGGERS", where data inserted in to the source table is transformed by the SQL query and immediately inserted into the target table. This is much different behavior and not really consistent with the dbt execution model, which is generally batch oriented.

@genzgd genzgd linked a pull request Nov 30, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants