Fix to failed to find unique target for patch #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of Argo workflows after v3.3.4 appear to have a namespace added to their install.yaml resources (see argoproj/argo-workflows#8280 and argoproj/argo-workflows#8250 (comment)), with causes an error when kustomization tries to apply updates: ``` ComparisonError rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build /tmp/https___github.com_climateimpactlab_downscalecmip6/infrastructure/kubernetes-gcp/argo` failed exit status 1: Error: no matches for Id ~G_v1_ConfigMap|~X|workflow-controller-configmap; failed to find unique target for patch ~G_v1_ConfigMap|workflow-controller-configmap 2022-06-02 18:16:15 -0700 PDT ``` This *might* relate to a bug in customization (see kubernetes-sigs/kustomize#1332). So we're specifying the namespace in the install.yaml resource when defining the patch for the customization with the hopes that it will be able to find its target.
|
Nope, this doesn't get it completely. Need to revert this and try something else. |
brews
added a commit
that referenced
this pull request
Jun 3, 2022
Changes from PR #617 didn't actually solve the problem.
brews
added a commit
that referenced
this pull request
Jun 3, 2022
Reverting changes from PR #617 because this didn't actually fix the problem.
This was referenced Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of Argo workflows after v3.3.4 appear to have a namespace added to their install.yaml resources (see argoproj/argo-workflows#8280 and argoproj/argo-workflows#8250 (comment)), with causes an error when kustomization tries to apply updates:
This might relate to a bug in customization (see kubernetes-sigs/kustomize#1332).
So we're specifying the namespace in the install.yaml resource when defining the patch for the customization with the hopes that it will be able to find its target.
flake8 downscale tests docs[summarize your pull request here]