Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put target ns in strategic merge patch to ID patch target for argo service account #620

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

brews
Copy link
Member

@brews brews commented Jun 3, 2022

Extension of fix from PR #617, PR #618, PR #619.

Applies a similar fix to the patchesStrategicMerge for argo-workflow's argo-server ServiceAccount. Apparently, kustomize can't find a unique target to apply the patch to after argo-workflows started hard coding the "argo" namespace in their install.yaml in >= v3.3.5.

In case anyone else has the problem, I found this after ArgoCD started reporting errors while syncing:

Message:            ComparisonError: rpc error: code = Unknown desc = `kustomize build /tmp/https___github.com_climateimpactlab_downscalecmip6/infrastructure/kubernetes-gcp/argo` failed exit status 1: Error: no matches for Id ~G_v1_ServiceAccount|~X|argo-server; failed to find unique target for patch ~G_v1_ServiceAccount|argo-server

This pops up after the upstream change from argoproj/argo-workflows#8280. Had no issues with updates and deployments before this change.

@brews brews added bug infrastructure Issues related to project cyberinfrastructure labels Jun 3, 2022
@brews brews self-assigned this Jun 3, 2022
@brews brews merged commit e871685 into master Jun 3, 2022
@brews brews deleted the argo_sa_fix branch June 3, 2022 03:00
@brews
Copy link
Member Author

brews commented Jun 3, 2022

If this solves the last of these issues with the update, it might be worth dropping an issue with argo-workflows to let them know about the break. At the very least it might help people with the same breaks from applying the newer patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug infrastructure Issues related to project cyberinfrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant