From 93aa8de050ab67fc15edb1d2b70ecf801ab6f37e Mon Sep 17 00:00:00 2001 From: Todd Murphy Date: Thu, 28 Nov 2024 14:06:03 +1000 Subject: [PATCH 1/2] main - FIX: Fix ephemeralStorageGiB property assignment in FargateRunnerProvider --- src/providers/fargate.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/fargate.ts b/src/providers/fargate.ts index b4e0a5c..4db9111 100644 --- a/src/providers/fargate.ts +++ b/src/providers/fargate.ts @@ -435,7 +435,7 @@ export class FargateRunnerProvider extends BaseProvider implements IRunnerProvid { cpu: props?.cpu ?? 1024, memoryLimitMiB: props?.memoryLimitMiB ?? 2048, - ephemeralStorageGiB: props?.ephemeralStorageGiB ?? !image.os.is(Os.WINDOWS) ? 25 : undefined, + ephemeralStorageGiB: props?.ephemeralStorageGiB ?? (!image.os.is(Os.WINDOWS) ? 25 : undefined), runtimePlatform: { operatingSystemFamily: os, cpuArchitecture: arch, From 9807697b500662010361066fd556a05498c0bb78 Mon Sep 17 00:00:00 2001 From: Amir Szekely Date: Thu, 28 Nov 2024 19:13:38 -0800 Subject: [PATCH 2/2] Update unit test --- test/providers.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/providers.test.ts b/test/providers.test.ts index 5261e36..52c26bf 100644 --- a/test/providers.test.ts +++ b/test/providers.test.ts @@ -39,7 +39,7 @@ test('CodeBuild provider privileged', () => { Environment: { PrivilegedMode: true, }, - }), 2/*runners*/+3/*image builders*/); + }), 2/*runners*/ + 3/*image builders*/); template.hasResourceProperties('AWS::CodeBuild::Project', Match.objectLike({ Environment: { @@ -73,6 +73,7 @@ test('Fargate provider', () => { new FargateRunnerProvider(stack, 'provider', { vpc: vpc, securityGroups: [sg], + ephemeralStorageGiB: 100, }); const template = Template.fromStack(stack); @@ -87,6 +88,7 @@ test('Fargate provider', () => { Name: 'runner', }, ], + EphemeralStorage: { SizeInGiB: 100 }, })); });