Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official docker image #433

Closed
bitphage opened this issue Jan 15, 2019 · 10 comments
Closed

Official docker image #433

bitphage opened this issue Jan 15, 2019 · 10 comments
Labels
epic [2] Good First Issue Good First Issue [4] Priority: High [5] Medium Task Indicates size of task. Est. between two and five hours

Comments

@bitphage
Copy link
Collaborator

I think we need to build and maintain official docker image for the project. Docker image is an easy and unified way to try the software and deploy onto VPS.

@thehapax
Copy link
Collaborator

agreed. sending a link to permie since i don't know what his github username is

@g3d
Copy link

g3d commented Jan 19, 2019

Hi guys, t.me/Don_Gabriel from Bitshares DEXbot chat build an initial docker image & shared it with me.

We've agreed to work together on next scope of improvements in fork of this repo:

  • Add README for dockerhub with description how to run it & how to mount uptick/dexbot-cli config folders
  • extract version to ENV variable with some defaults, so we can easily re-build upgraded version without change single line of code if needed
  • update ENV to prevent crashes due to lack of locales variables
  • update PATH, so no need to use ~/.local/bin prefix
  • run as non-root user
  • connect CI pipeline so it can build & distribute docker images (to https://hub.docker.com/u/dexbot) automatically during dexbot release tag push

After this is done, we will send PR back to this repo.

@thehapax @bitfag feel free to tell us about other points if we missed anything.

P.S. I think we can assign this to me & add milestone

@bitphage
Copy link
Collaborator Author

We didn't started 2019 development yet, so there is no established workflow. @PermieBTS please take a look.

@gabev
Copy link
Collaborator

gabev commented Jan 24, 2019

Regarding the docker DEXBot Cli image ...just pushed a new image to the docker hub tonight ...now ENV for LC and LANG works and also created an user dexbot with password dexbot and added to sudoers and set the WORKDIR to DEXBot-0.9.5 ... image is based on Ubuntu 18.04

@thehapax
Copy link
Collaborator

Ok I will discuss with Permie and then see if we can get this task assigned to you @g3d @PermieBTS

@thehapax
Copy link
Collaborator

@PermieBTS can we get @g3d added as a contributor?

@thehapax thehapax added [2] Good First Issue Good First Issue [5] Medium Task Indicates size of task. Est. between two and five hours labels Feb 5, 2019
@bitphage bitphage added the epic label Feb 15, 2019
@g3d
Copy link

g3d commented Feb 25, 2019

@PermieBTS why closed?

@PermieBTS PermieBTS reopened this Feb 26, 2019
@PermieBTS
Copy link
Collaborator

My understanding from gabriel was the docker was sufficient.
Apologies, ive re-opened

@bitphage
Copy link
Collaborator Author

bitphage commented Apr 24, 2019

As users have issues installing dexbot (#565), and we do not have automatic installation test which tests the HOWTO, I want to pay attention to this issue. What I want to do:

  • Refactor Dockerfile from [WIP] Official docker image #439 (already done locally)
  • Enable automatic build of docker image using Travis CI for test purposes
  • Enable automatic build of docker images at the Docker Hub side for master and devel branches

@bitphage
Copy link
Collaborator Author

#439 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic [2] Good First Issue Good First Issue [4] Priority: High [5] Medium Task Indicates size of task. Est. between two and five hours
Projects
None yet
Development

No branches or pull requests

5 participants