Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO: keep virtual orders state across restart #442

Closed
bitphage opened this issue Feb 3, 2019 · 2 comments
Closed

SO: keep virtual orders state across restart #442

bitphage opened this issue Feb 3, 2019 · 2 comments

Comments

@bitphage
Copy link
Collaborator

bitphage commented Feb 3, 2019

Currently virtual orders are being reconstructed from scratch on each restart. This creates the following issues:

  • If working mode changed & dexbot restarted, virtual orders will be restored according to a new mode. When switching from valley mode to mountain or neutral, this will create available funds which will be reallocated into closer-to-center orders.
  • If orders size increase round is in progress, increase smoothness will be distorted

Solution: save virtual orders into state, and restore them on startup. Determine how to better store virtual orders. As a state, dexbot sqlite db may be used, or json serialized dump file, or something other. Determine what is best.

@MarkoPaasila
Copy link
Collaborator

This is important. If operational depth is max, then the orders themselves contain all necessary information, but if we only place orders to some depth, then it is necessary to remember state. Otherwise we make losses.

@PermieBTS
Copy link
Collaborator

If working mode changed & dexbot restarted, virtual orders will be restored according to a new mode. When switching from valley mode to mountain or neutral, this will create available funds which will be reallocated into closer-to-center orders.

Restarting DEXBot after a strategy mode change may be a common "mistake" users make so I think during the refactor a way to store orders across restart should be developed.
This is a kind of polishing of the user experience as well.
DEXBot should be easy to configure (if you know what you're doing with market making) and the possibility that the user harms their strategy accidentally should be prevented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants