fix: prevent extra iterations occurring on getRunIdAndUrl

Codex- · Oct 26, 2024 · b838ffd · b838ffd
1 parent 5477224
commit b838ffd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/return-dispatch.spec.ts b/src/return-dispatch.spec.ts
@@ -779,7 +779,7 @@ describe("return-dispatch", () => {
 
         const getRunIdAndUrlPromise = getRunIdAndUrl({
           ...defaultOpts,
-          workflowTimeoutMs: 10 * 1000,
+          workflowTimeoutMs: 15 * 1000,
         });
 
         // First attempt

diff --git a/src/return-dispatch.ts b/src/return-dispatch.ts
@@ -146,7 +146,6 @@ export async function getRunIdAndUrl({
   let elapsedTime = Date.now() - startTime;
   while (elapsedTime < workflowTimeoutMs) {
     attemptNo++;
-    elapsedTime = Date.now() - startTime;
 
     // Get all runs for a given workflow ID
     const fetchWorkflowRunIds = await api.retryOrTimeout(
@@ -180,6 +179,7 @@ export async function getRunIdAndUrl({
     }
 
     await sleep(constants.WORKFLOW_JOB_STEPS_RETRY_MS);
+    elapsedTime = Date.now() - startTime;
   }
 
   return { success: false, reason: "timeout" };