Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan config has so many excluded files - need to clean #1044

Closed
2 tasks
rathorevaibhav opened this issue Sep 29, 2021 · 0 comments
Closed
2 tasks

PHPStan config has so many excluded files - need to clean #1044

rathorevaibhav opened this issue Sep 29, 2021 · 0 comments
Assignees
@rathorevaibhav @GauravGusain98
Labels
priority : high !! Important to fix within couple of days. status : ready to test Items that are ready for testing
Milestone
Oct 02 - Oct 08, ...

Comments

@rathorevaibhav
Copy link
Member

Describe the task
The phpstan config file phpstan.neon has so many excluded paths. It seems like we're ignoring a lot of things on coding practice but not sure why and the reason.

Expected behavior

  • Figure out which files should be ignored. The rest should be removed from excluded paths and fixes to be implemented to pass coding standard checks.
  • For files that need to be excluded, there should be proper comments/documentation on why they have are exclued
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rathorevaibhav rathorevaibhav

@GauravGusain98 GauravGusain98

Labels
priority : high !! Important to fix within couple of days. status : ready to test Items that are ready for testing
Projects
None yet
Milestone
Oct 02 - Oct 08, 2021
Development

No branches or pull requests
2 participants
@rathorevaibhav @GauravGusain98