Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting payment information fields for International invoices. #921

Closed
mohitsharma-22 opened this issue Aug 30, 2021 · 8 comments
Closed
Assignees
Labels
module : finance Items related to Finance module priority : critical !!! Need to be fixed immediately. Leave everything else and fix this! status : ready to test Items that are ready for testing type : bug 🐛

Comments

@mohitsharma-22
Copy link
Member

mohitsharma-22 commented Aug 30, 2021

Describe the bug
We select paid from the drop-down to save the payment details received for invoices.
I am not able to get the "Payment Information:" details for international invoices. Seems to be a Bug. Please check and fix it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Employee portal.
  2. Click the invoices link from Finance dropdown.
  3. Click on any international invoice.
  4. Select paid from the Status drop down.
  5. In the Right panel Payment Information: section should appear to fill up the details on the payment received against the invoice.
  6. Payment Information: section is not showing up for international invoices. It is working fine for Indian invoices.

Screenshots
Screenshot 2021-08-30 at 3 09 03 PM

@mohitsharma-22 mohitsharma-22 added priority : critical !!! Need to be fixed immediately. Leave everything else and fix this! type : bug 🐛 module : finance Items related to Finance module labels Aug 30, 2021
@mohitsharma-22 mohitsharma-22 changed the title Not getting payment information fields for International invocies. Not getting payment information fields for International invoices. Aug 30, 2021
@rathorevaibhav
Copy link
Member

Might be a side-effect of changes done in this PR #852

@rathorevaibhav
Copy link
Member

rathorevaibhav commented Aug 30, 2021

This is deployed on UAT. @kickb71 please test on UAT. I'll then merge to production.

@gautam071
Copy link
Contributor

This is deployed on UAT. @kickb71 please test on UAT. I'll then merge to production.

Sure sir let me check @rathorevaibhav

@gautam071
Copy link
Contributor

@rathorevaibhav It works perfectly on UAT.

@rathorevaibhav
Copy link
Member

@mohitsharma-22 this is deployed on Production. Please check.

@mohitsharma-22
Copy link
Member Author

@rathorevaibhav I am able to see the payment information section now and am able to add the details.

Only one issue, the value of Conversion Rate Diff: is not getting saved now. It gets removed while saving the invoice. Can you please check?

Screenshot 2021-08-31 at 10 24 02 AM

@gautam071
Copy link
Contributor

@mohitsharma-22 The issue is solved & made PR

@mohitsharma-22
Copy link
Member Author

@rathorevaibhav It is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module : finance Items related to Finance module priority : critical !!! Need to be fixed immediately. Leave everything else and fix this! status : ready to test Items that are ready for testing type : bug 🐛
Projects
None yet
Development

No branches or pull requests

3 participants