Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The API for the conversion of USD to INR not found #998

Closed
1 task
gautam071 opened this issue Sep 16, 2021 · 1 comment · Fixed by #1031
Closed
1 task

The API for the conversion of USD to INR not found #998

gautam071 opened this issue Sep 16, 2021 · 1 comment · Fixed by #1031
Assignees
@rathorevaibhav
Labels
module : finance Items related to Finance module Points: 2 Good for intermediates. Tasks that require around 4-8 hours to finish. status : ready to test Items that are ready for testing
Milestone
Sep 18 - Sep 24, ...

Comments

@gautam071
Copy link
Contributor

gautam071 commented Sep 16, 2021 •
edited by bharatsingh100
Loading

Is your feature request related to a problem? Please describe.
The API keys are not found in the local when opening the finance page

Describe the solution you'd like
- Make the API key
- Error message should pop up saying "the API server fails to produce the values"

Additional context
Screenshot 2021-09-16 at 2 10 33 PM

Package Link

  1. https://github.com/orkhanahmadov/laravel-currencylayer

Expected Outcome

  • The connection with external API should be made only if API key is available in the env file. If it's absent, then system should not make the API call and instead use a hardcoded value from config.
@gautam071 gautam071 self-assigned this Sep 16, 2021
@rathorevaibhav rathorevaibhav added the Points: 2 Good for intermediates. Tasks that require around 4-8 hours to finish. label Sep 23, 2021
@bharatsingh100 bharatsingh100 self-assigned this Sep 23, 2021
@bharatsingh100 bharatsingh100 linked a pull request Sep 24, 2021 that will close this issue
added check for currency-exchange-rate api key present in the env #1031
Merged
1 task
@bharatsingh100 bharatsingh100 mentioned this issue Sep 25, 2021
Merged
1 task
@rathorevaibhav rathorevaibhav added the module : finance Items related to Finance module label Sep 25, 2021
@bharatsingh100 bharatsingh100 added the status : ready to test Items that are ready for testing label Sep 29, 2021
@rathorevaibhav
Copy link
Member

This works great! Thanks @bharatsingh100 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rathorevaibhav rathorevaibhav

Labels
module : finance Items related to Finance module Points: 2 Good for intermediates. Tasks that require around 4-8 hours to finish. status : ready to test Items that are ready for testing
Projects
None yet
Milestone
Sep 18 - Sep 24, 2021
Development

Successfully merging a pull request may close this issue.

added check for currency-exchange-rate api key present in the env ColoredCow/portal
3 participants
@rathorevaibhav @bharatsingh100 @gautam071