Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic version from uv.lock files #490

Closed
22 tasks done
redeboer opened this issue Jan 17, 2025 · 2 comments
Closed
22 tasks done

Remove dynamic version from uv.lock files #490

redeboer opened this issue Jan 17, 2025 · 2 comments
Assignees
Labels
🐛 Bug Something isn't working 🔨 Maintenance Maintenance and upkeep improvements
Milestone

Comments

@redeboer
Copy link
Member

redeboer commented Jan 17, 2025

Since uv v0.5.19, the version of an editable package that dynamically sets the version (e.g. with setuptools-scm) is not stored to the uv.lock file anymore. This results in problems like these:
https://github.com/ComPWA/ampform/actions/runs/12827104659/job/35770965965

It is actually nice to not have the version stored in the lock file. See for instance ComPWA/ampform#446, where the uv.lock had to be updated after AmpForm got a new release tag.

The following repositories have uv.lock files:
https://github.com/search?q=org%3AComPWA+path%3A%2F%5Euv.lock%24%2F&type=code
and these projects set setuptools-scm to remove the commit from the version:
https://github.com/search?q=org%3AComPWA+path%3Apyproject.toml+%2Flocal_scheme+%3D+%22no-local-version%22%2F&type=code

Creating a PR for these is quite simple. First, make sure you have the latest version of uv and your installed tools like pre-commit-uv and tox-uv:

uv self update
uv tool upgrade --all

then create a branch, update all the lock files, and create a PR:

git stash
git fetch --all
git checkout -b update-lock origin/main

uv lock
pre-commit autoupdate --repo https://github.com/astral-sh/uv-pre-commit
git commit -am 'MAINT: remove dynamic version from `uv.lock`'

uv lock --upgrade & pre-commit autoupdate -j$(nproc) & wait
git commit -nam 'MAINT: update lock files'

git push origin update-lock -u

Tasks

Preview Give feedback
  1. 🐛 Bug 🔨 Maintenance 🖱️ DX
    grayson-helmholz
  2. 🔨 Maintenance 🖱️ DX
    grayson-helmholz
  3. 🔨 Maintenance
    grayson-helmholz
  4. 🔨 Maintenance
    grayson-helmholz
  5. 🔨 Maintenance
    grayson-helmholz
  6. 🔨 Maintenance
    grayson-helmholz
  7. 🔨 Maintenance
    grayson-helmholz
  8. 🔨 Maintenance
    grayson-helmholz
  9. 🔨 Maintenance 🖱️ DX
    grayson-helmholz redeboer
  10. 🔨 Maintenance 🖱️ DX
    grayson-helmholz
  11. 🔨 Maintenance 🖱️ DX
    grayson-helmholz
  12. 🔨 Maintenance
    grayson-helmholz
  13. 🔨 Maintenance
    grayson-helmholz
  14. 🔨 Maintenance 🖱️ DX
    redeboer
  15. 🔨 Maintenance 🖱️ DX
    redeboer
  16. 🔨 Maintenance
    grayson-helmholz
  17. 🔨 Maintenance 🖱️ DX
    grayson-helmholz
  18. 🔨 Maintenance
    redeboer
  19. 🔨 Maintenance 🖱️ DX
    redeboer
@grayson-helmholz
Copy link

grayson-helmholz commented Jan 24, 2025

https://github.com/ComPWA/K-matrix-research
https://github.com/ComPWA/Nstar-docs
https://github.com/ComPWA/PWA-JPsi2pbarSigmaKS
NOT REACHABLE

@redeboer
Copy link
Member Author

https://github.com/ComPWA/PWA-JPsi2pbarSigmaKS

This one should be accessible now. Access is also needed for https://github.com/ComPWA/PWA-JPsi2pbarSigmaKS/issues/122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

No branches or pull requests

2 participants