Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing versions as saved in workflow.json #236

Open
kampelmuehler opened this issue Jan 30, 2025 · 7 comments
Open

Managing versions as saved in workflow.json #236

kampelmuehler opened this issue Jan 30, 2025 · 7 comments
Labels
enhancement New feature or request

Comments

@kampelmuehler
Copy link

kampelmuehler commented Jan 30, 2025

Describe the solution you'd like

Since a more recent update to Comfy manager the versions of custom nodes used in the workflow are saved in workflow.json. If I understand correctly the nodes feature of the cli doesn't currently recognize/implement any sort of versioning.
The solution I'd like would be for the cli to automatically install the correct versions of custom nodes referenced in workflow.json.

Describe alternatives you've considered

The alternative would be a manual workaround to keep the correct version. Also comfy manager cli doesn't appear to use versioning/registry yet.

Additional context

/

@kampelmuehler kampelmuehler added the enhancement New feature or request label Jan 30, 2025
@ltdrdata
Copy link
Member

ltdrdata commented Jan 30, 2025

  1. The utilization of information embedded in the workflow has already been planned.
  2. The utilization of comfyregsitry (CNR) has already been implemented. Items labeled as UNKNOWN are non-CNR nodes, while those with a specified version are CNR nodes. The second column represents the node ID, which can be used for installation. comfy-cli node install <node ID>@<node version>

Image

for example.

comfy-cli node install [email protected]

Image

@kampelmuehler
Copy link
Author

Thanks for the quick reply, much appreciated.

Does that mean that a work around would be to go through the list in the json representation of the workflow, for example

    "node_versions": {
      "comfy-core": "0.3.12",
      "comfyui-kjnodes": "1.0.5"
    }

and run cli node install <node ID>@<node version> for each element?

@ltdrdata
Copy link
Member

ltdrdata commented Jan 30, 2025

Thanks for the quick reply, much appreciated.

Does that mean that a work around would be to go through the list in the json representation of the workflow, for example

    "node_versions": {
      "comfy-core": "0.3.12",
      "comfyui-kjnodes": "1.0.5"
    }

and run cli node install <node ID>@<node version> for each element?

Yup!
If it is not a CNR node, you can explicitly specify it as <repo name>@unknown.
If you want to install the linked GitHub version instead of the versioned package of CNR, you can specify it as <node ID>@nightly.

@kampelmuehler
Copy link
Author

Cool, thanks a lot.

Does <node ID>@<commit hash> for git repos not work?

@kampelmuehler
Copy link
Author

Answering my own question: commit hashes don't work, but when workflows are exported for nightly versions the commit hashes are exported. I'd argue it's somewhat required to be able to do comfy node install <node ID>@<commit hash>

@ltdrdata
Copy link
Member

ltdrdata commented Feb 4, 2025

Answering my own question: commit hashes don't work, but when workflows are exported for nightly versions the commit hashes are exported. I'd argue it's somewhat required to be able to do comfy node install <node ID>@<commit hash>

I'll update it soon or later.
It will be patched on ComfyUI-Manager.

@kampelmuehler
Copy link
Author

kampelmuehler commented Feb 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants