Update XAML Behaviors Dependency

[michael-hawker]

We should update the XAML Behaviors dependency we have from 1.1 to 2.x. I'm not sure if there are breaking changes or not, but assuming they have more functionality. Some research needs to be done here to understand the ramifications, especially if those are breaking changes or not.

[michael-hawker]

This is crashing users in the French locale, see microsoft/XamlBehaviors#154

[michael-hawker]

@Jasonstein let us know if you plan to pick this up when you have time. Should just be a matter of doing some tests of the Toolkit behaviors (we have some that have sample pages in the Sample app)

[0x7c13]

@Jasonstein let us know if you plan to pick this up when you have time. Should just be a matter of doing some tests of the Toolkit behaviors (we have some that have sample pages in the Sample app)

I will take a look this week and share my findings here.

[michael-hawker]

Thanks @Jasonstein, much appreciated! I've assigned this issue to you for tracking.

We have better Unit Test infrastructure in our CI now, so not sure if that helps in fortifying any existing code paths.

[0x7c13]

Here is my updates regarding to upgrading Behaviors package:

WCT Projects having direct references to "Microsoft.Xaml.Behaviors.Uwp.Managed":

• Microsoft.Toolkit.Uwp.SampleApp.csproj
• Microsoft.Toolkit.Uwp.UI.csproj
• Microsoft.Toolkit.Uwp.UI.Animations.csproj

All currently are using version 1.1.0 and needs to upgrade to v2.0.1 (latest ver).
I tried to upgrade all of them and build/run without any issues.

Here is the list of Microsoft.Xaml.Interactivity usage in WCT repo:

I checked all of them in samples app after upgrading the package and I did not observe anything abnormal or crashes.

Then finally I took a look a the changes made between v1.1.0 <-> v2.0.1 and I can see most of them are refactorings and depency upgrades. I do not see any breaking changes or API level changes.

Changes between v1.1.0 <-> v2.0.1:
microsoft/XamlBehaviors@1.1.0...v2.0.1

Conclusion is that I think it is safe to upgrade to 2.0.1.

Here is the PR:
#3235

@michael-hawker The crashing bug that Sergio shared happens for both v1.1.0 and v2.0.1 so I do not think that will be a blocker for this upgrades right?

[michael-hawker]

Thanks @Jasonstein! We'll take a look at the PR and get this in for 6.1. We wouldn't block this on the other issue Sergio found as it's still an issue, if anything we know we should update the minor version if they get a fix in before we ship.