You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
With cis2client, we can only call a handful of methods like transfer, balanceOf etc. But ideally we would wanna call burn, mint and many more. This would help users call any method from the token contract which implements cis2. Users can use the invoke_contract implemented by Host but the error handling is better in cis2client which is customized for it.
Solution
Make the invoke_contract found in cis2client as public.
Here:
I don't think it's right to make this public since invoking other methods does not have anything to do with cis2.
However if I read your feedback more broadly, it would make sense to add a method to HasHost that automatically parses the response into a type you provide instead of returning the raw return value.
This seems like it would accomplish what you want, right?
oh yes indeed. Yes thats what i would love to achieve. Looking at cis2 invoke contract, i was able to do the same. But having it done by invoke_contract would be ideal. Thanks
Description
With
cis2client
, we can only call a handful of methods liketransfer
,balanceOf
etc. But ideally we would wanna callburn
,mint
and many more. This would help users call any method from the token contract which implementscis2
. Users can use theinvoke_contract
implemented byHost
but the error handling is better incis2client
which is customized for it.Solution
Make the
invoke_contract
found incis2client
as public.Here:
concordium-rust-smart-contracts/concordium-cis2/src/cis2_client.rs
Line 367 in 4acf34e
The similar can be done for
invoke_contract_read_only
method as well.The text was updated successfully, but these errors were encountered: