Add encode_hex helper to ensure hex strings have "0x" prefix #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix corresponds to the lines mentioned in #26 |
|
Maybe the add_0x_prefix from ethereum-utils can be a cleaner way to achieve this? |
|
I still get the hex error when I use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
encode_hexfunction to utils that just calls.encode('hex')on its input and prepends0xto it. I replaced all the occurrences ofthing.encode('hex')with it, so geth should accept things now.Seems to work for me, but I haven't done extensive testing yet.
Closes #26